Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR #4486 (until we understand the segfault under PR #4500) #4501

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Feb 8, 2023

This reverts commit b2c1978.

See #4500 for background.

Description

Suggested changelog entry:

@rwgk rwgk marked this pull request as ready for review February 8, 2023 00:29
@rwgk rwgk requested a review from Skylion007 February 8, 2023 00:30
@rwgk
Copy link
Collaborator Author

rwgk commented Feb 8, 2023

Thanks Aaron!

@rwgk rwgk merged commit f8713ec into pybind:master Feb 8, 2023
@rwgk rwgk deleted the rollback_pr4459 branch February 8, 2023 00:55
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Feb 8, 2023
@rwgk rwgk changed the title Revert PR #4459 (until we understand the segfault under PR #4500) Revert PR #4486 (until we understand the segfault under PR #4500) Feb 8, 2023
@rwgk
Copy link
Collaborator Author

rwgk commented Feb 8, 2023

Sorry, I had the PR number wrong, I just changed the title of this PR to point back to #4486.

@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants