Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): create handle_type_name specialization to type-hint variable length tuples #5051

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

watsonjj
Copy link
Contributor

@watsonjj watsonjj commented Mar 8, 2024

Description

Adds a template specialization for handle_type_name in typing.h to allow the type hinting of a variable-length tuple, resulting in the hint tuple[Any, ...].

Suggested changelog entry:

Create ``handle_type_name`` specialization to type-hint variable length tuples

Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@henryiii henryiii force-pushed the variable_length_tuple_type_hint branch from 72e99f9 to 03c701c Compare March 21, 2024 06:30
@henryiii henryiii merged commit 65370f3 into pybind:master Mar 21, 2024
84 checks passed
@henryiii henryiii added the needs changelog Possibly needs a changelog entry label Mar 27, 2024
@henryiii henryiii changed the title Create handle_type_name specialization to type-hint variable length tuples fix(types): create handle_type_name specialization to type-hint variable length tuples Mar 27, 2024
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants