Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.10, 3.11, 3.12 to win32 job matrix. #5179

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Jun 20, 2024

Description

Increase test coverage (before dropping Python 3.6 and 3.7). — Without this PR the win32 job matrix was getting rather small (just two jobs left after removing 3.6 and 3.7).

win32 scipy wheels don't seem to exist for Python >= 3.10.

Suggested changelog entry:

@rwgk rwgk changed the title WIP: Add Python 3.10, 3.11, 3.12 to win32 job matrix. Add Python 3.10, 3.11, 3.12 to win32 job matrix. Jun 20, 2024
@rwgk rwgk marked this pull request as ready for review June 20, 2024 13:59
@rwgk rwgk requested a review from henryiii as a code owner June 20, 2024 13:59
rwgk pushed a commit to rwgk/pybind11 that referenced this pull request Jun 20, 2024
@henryiii
Copy link
Collaborator

Could you add the commit that removes the if: on the 3.8+ jobs?

@rwgk
Copy link
Collaborator Author

rwgk commented Jun 21, 2024

Could you add the commit that removes the if: on the 3.8+ jobs?

Works!

@rwgk rwgk merged commit 5552cbf into pybind:master Jun 21, 2024
86 checks passed
@rwgk rwgk deleted the win32_py310plus branch June 21, 2024 14:41
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jun 21, 2024
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Jun 21, 2024
henryiii added a commit that referenced this pull request Jun 22, 2024
* Change Python version guard: PYTHON < 3.7 IS UNSUPPORTED.

* Replace or remove Python 3.6 jobs.

* Move appveyor to Python 3.8

* Change `[tool.pylint]` `master.py-version` from `3.6` to `3.8`

* Change `[tool.pylint]` `master.py-version` to `3.7`

* Remove `centos:7` job; Change almalinux:8 job to use Python 3.8

* Try 🐍 3.8 • ubuntu-20.04 • x64 without `-DCMAKE_CXX_FLAGS="-D_=1"`

* Update setup.cfg as suggested by @henryiii

* Try running `cmake --build . --target cpptest` on all platforms (`standard` job).

* Disable deadsnakes jobs entirely.

* Apply PR #5179: Add Python 3.10, 3.11, 3.12 to win32 job matrix.

* Add back `-DCMAKE_CXX_FLAGS="-D_=1"` but do not install boost in that case.

* PY_VERSION_HEX < 3.7 cleanup pass: include/pybind11

* WITH_THREAD cleanup pass: include/pybind11

* Undo incorrect change.

* Revert "Disable deadsnakes jobs entirely."

This reverts commit bbcd008.

* WITH_THREAD cleanup pass: tests/

* Change Python version guard in pybind11/__init__.py: pybind11 does not support Python < 3.7.

* Misc cleanup pass

* chore: use future imports

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>

* Update tests/test_numpy_array.py

* Update test_numpy_array.py

---------

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Co-authored-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii pushed a commit that referenced this pull request Jul 24, 2024
* Fix typo.

* Remove outdated known limitation.

See #5179.
henryiii pushed a commit that referenced this pull request Aug 12, 2024
* Fix typo.

* Remove outdated known limitation.

See #5179.
henryiii pushed a commit that referenced this pull request Aug 13, 2024
* Fix typo.

* Remove outdated known limitation.

See #5179.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants