-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: a compilation error with gcc 14 fixed #5208
Conversation
Should gcc 14 be added to the CI matrix? |
Thanks! |
Oh, yes. Sorry looks like I was too fast. But: Maybe it's not actually GCC 14 specific? But related to what other includes are in user code? |
What I mean: What's really missing is automatic checks for IWYU correctness. (I think it's a difficult project to add that.) |
Makes sense |
If someone wants to work on IWYU, this is what we use Google-internally: I GUESS we could run https://clangd.llvm.org/design/include-cleaner under GHA. I never got a chance to look any deeper. For completeness: Google-internally the pybind11 client code is kept IWYU clean, but pybind11 itself is not. (That would have to happen here.) |
fixes a compilation error with gcc 14.
fixes a compilation error with gcc 14.
Description
Fixes #5206, which is caused by a missed header
algorithm
.Suggested changelog entry:
A missing ``#include <algorithm>`` in pybind11/typing.h was added to fix build errors (in case user code does not already depend on that include).