PR #5257 latest but fresh on smart_holder (as one commit)

CMakeLists.txt

@@ -154,10 +154,9 @@ set(PYBIND11_HEADERS
  include/pybind11/detail/init.h
  include/pybind11/detail/internals.h
  include/pybind11/detail/smart_holder_poc.h
- include/pybind11/detail/smart_holder_sfinae_hooks_only.h
- include/pybind11/detail/smart_holder_type_casters.h
  include/pybind11/detail/type_caster_base.h
  include/pybind11/detail/typeid.h
+ include/pybind11/detail/using_smart_holder.h
  include/pybind11/detail/value_and_holder.h
  include/pybind11/attr.h
  include/pybind11/buffer_info.h

include/pybind11/attr.h

@@ -331,6 +331,10 @@ struct type_record {
  /// Is the class inheritable from python classes?
  bool is_final : 1;
 
+#ifdef PYBIND11_HAVE_INTERNALS_WITH_SMART_HOLDER_SUPPORT
+ holder_enum_t holder_enum_v = holder_enum_t::undefined;
+#endif
+
  PYBIND11_NOINLINE void add_base(const std::type_info &base, void *(*caster)(void *) ) {
  auto *base_info = detail::get_type_info(base, false);
  if (!base_info) {

include/pybind11/detail/common.h

@@ -9,13 +9,13 @@
 
 #pragma once
 
-#define PYBIND11_VERSION_MAJOR 2
-#define PYBIND11_VERSION_MINOR 14
+#define PYBIND11_VERSION_MAJOR 3
+#define PYBIND11_VERSION_MINOR 0
 #define PYBIND11_VERSION_PATCH 0.dev1
 
 // Similar to Python's convention: https://docs.python.org/3/c-api/apiabiversion.html
 // Additional convention: 0xD = dev
-#define PYBIND11_VERSION_HEX 0x020E00D1
+#define PYBIND11_VERSION_HEX 0x030000D1
 
 // Define some generic pybind11 helper macros for warning management.
 //

include/pybind11/detail/init.h

@@ -10,7 +10,7 @@
 #pragma once
 
 #include "class.h"
-#include "smart_holder_sfinae_hooks_only.h"
+#include "using_smart_holder.h"
 
 PYBIND11_NAMESPACE_BEGIN(PYBIND11_NAMESPACE)
 
@@ -156,9 +156,7 @@ void construct(value_and_holder &v_h, Alias<Class> *alias_ptr, bool) {
 // holder. This also handles types like std::shared_ptr<T> and std::unique_ptr<T> where T is a
 // derived type (through those holder's implicit conversion from derived class holder
 // constructors).
-template <typename Class,
- detail::enable_if_t<!detail::type_uses_smart_holder_type_caster<Cpp<Class>>::value, int>
- = 0>
+template <typename Class, detail::enable_if_t<!is_smart_holder<Holder<Class>>::value, int> = 0>
 void construct(value_and_holder &v_h, Holder<Class> holder, bool need_alias) {
  PYBIND11_WORKAROUND_INCORRECT_MSVC_C4100(need_alias);
  auto *ptr = holder_helper<Holder<Class>>::get(holder);
@@ -200,10 +198,18 @@ void construct(value_and_holder &v_h, Alias<Class> &&result, bool) {
  v_h.value_ptr() = new Alias<Class>(std::move(result));
 }
 
+#ifdef PYBIND11_HAVE_INTERNALS_WITH_SMART_HOLDER_SUPPORT
+
+template <typename T, typename D>
+smart_holder init_smart_holder_from_unique_ptr(std::unique_ptr<T, D> &&unq_ptr,
+ bool void_cast_raw_ptr) {
+ void *void_ptr = void_cast_raw_ptr ? static_cast<void *>(unq_ptr.get()) : nullptr;
+ return smart_holder::from_unique_ptr(std::move(unq_ptr), void_ptr);
+}
+
 template <typename Class,
  typename D = std::default_delete<Cpp<Class>>,
- detail::enable_if_t<detail::type_uses_smart_holder_type_caster<Cpp<Class>>::value, int>
- = 0>
+ detail::enable_if_t<is_smart_holder<Holder<Class>>::value, int> = 0>
 void construct(value_and_holder &v_h, std::unique_ptr<Cpp<Class>, D> &&unq_ptr, bool need_alias) {
  PYBIND11_WORKAROUND_INCORRECT_MSVC_C4100(need_alias);
  auto *ptr = unq_ptr.get();
@@ -217,30 +223,27 @@ void construct(value_and_holder &v_h, std::unique_ptr<Cpp<Class>, D> &&unq_ptr,
  // trampoline Python object alive. For types that don't inherit from enable_shared_from_this
  // it does not matter if void_cast_raw_ptr is true or false, therefore it's not necessary
  // to also inspect the type.
- auto smhldr = type_caster<Cpp<Class>>::smart_holder_from_unique_ptr(
+ auto smhldr = init_smart_holder_from_unique_ptr(
  std::move(unq_ptr), /*void_cast_raw_ptr*/ Class::has_alias && is_alias<Class>(ptr));
  v_h.value_ptr() = ptr;
  v_h.type->init_instance(v_h.inst, &smhldr);
 }
 
 template <typename Class,
  typename D = std::default_delete<Alias<Class>>,
- detail::enable_if_t<detail::type_uses_smart_holder_type_caster<Alias<Class>>::value, int>
- = 0>
+ detail::enable_if_t<is_smart_holder<Holder<Class>>::value, int> = 0>
 void construct(value_and_holder &v_h,
  std::unique_ptr<Alias<Class>, D> &&unq_ptr,
  bool /*need_alias*/) {
  auto *ptr = unq_ptr.get();
  no_nullptr(ptr);
- auto smhldr = type_caster<Alias<Class>>::smart_holder_from_unique_ptr(
- std::move(unq_ptr), /*void_cast_raw_ptr*/ true);
+ auto smhldr
+ = init_smart_holder_from_unique_ptr(std::move(unq_ptr), /*void_cast_raw_ptr*/ true);
  v_h.value_ptr() = ptr;
  v_h.type->init_instance(v_h.inst, &smhldr);
 }
 
-template <typename Class,
- detail::enable_if_t<detail::type_uses_smart_holder_type_caster<Cpp<Class>>::value, int>
- = 0>
+template <typename Class, detail::enable_if_t<is_smart_holder<Holder<Class>>::value, int> = 0>
 void construct(value_and_holder &v_h, std::shared_ptr<Cpp<Class>> &&shd_ptr, bool need_alias) {
  PYBIND11_WORKAROUND_INCORRECT_MSVC_C4100(need_alias);
  auto *ptr = shd_ptr.get();
@@ -249,24 +252,24 @@ void construct(value_and_holder &v_h, std::shared_ptr<Cpp<Class>> &&shd_ptr, boo
  throw type_error("pybind11::init(): construction failed: returned std::shared_ptr pointee "
  "is not an alias instance");
  }
- auto smhldr = type_caster<Cpp<Class>>::smart_holder_from_shared_ptr(shd_ptr);
+ auto smhldr = smart_holder::from_shared_ptr(shd_ptr);
  v_h.value_ptr() = ptr;
  v_h.type->init_instance(v_h.inst, &smhldr);
 }
 
-template <typename Class,
- detail::enable_if_t<detail::type_uses_smart_holder_type_caster<Alias<Class>>::value, int>
- = 0>
+template <typename Class, detail::enable_if_t<is_smart_holder<Holder<Class>>::value, int> = 0>
 void construct(value_and_holder &v_h,
  std::shared_ptr<Alias<Class>> &&shd_ptr,
  bool /*need_alias*/) {
  auto *ptr = shd_ptr.get();
  no_nullptr(ptr);
- auto smhldr = type_caster<Alias<Class>>::smart_holder_from_shared_ptr(shd_ptr);
+ auto smhldr = smart_holder::from_shared_ptr(shd_ptr);
  v_h.value_ptr() = ptr;
  v_h.type->init_instance(v_h.inst, &smhldr);
 }
 
+#endif // PYBIND11_HAVE_INTERNALS_WITH_SMART_HOLDER_SUPPORT
+
 // Implementing class for py::init<...>()
 template <typename... Args>
 struct constructor {

include/pybind11/detail/internals.h

@@ -16,7 +16,6 @@
 #endif
 
 #include "../pytypes.h"
-#include "smart_holder_sfinae_hooks_only.h"
 
 #include <exception>
 #include <mutex>
@@ -37,7 +36,9 @@
 /// further ABI-incompatible changes may be made before the ABI is officially
 /// changed to the new version.
 #ifndef PYBIND11_INTERNALS_VERSION
-# if PY_VERSION_HEX >= 0x030C0000 || defined(_MSC_VER)
+# if PYBIND11_VERSION_MAJOR >= 3
+# define PYBIND11_INTERNALS_VERSION 6
+# elif PY_VERSION_HEX >= 0x030C0000 || defined(_MSC_VER)
 // Version bump for Python 3.12+, before first 3.12 beta release.
 // Version bump for MSVC piggy-backed on PR #4779. See comments there.
 # define PYBIND11_INTERNALS_VERSION 5
@@ -237,6 +238,20 @@ struct internals {
  }
 };
 
+#if PYBIND11_INTERNALS_VERSION >= 6
+
+# define PYBIND11_HAVE_INTERNALS_WITH_SMART_HOLDER_SUPPORT
+
+enum class holder_enum_t : uint8_t {
+ undefined,
+ std_unique_ptr, // Default, lacking interop with std::shared_ptr.
+ std_shared_ptr, // Lacking interop with std::unique_ptr.
+ smart_holder, // Full std::unique_ptr / std::shared_ptr interop.
+ custom_holder,
+};
+
+#endif
+
 /// Additional type information which does not fit into the PyTypeObject.
 /// Changes to this struct also require bumping `PYBIND11_INTERNALS_VERSION`.
 struct type_info {
@@ -260,9 +275,14 @@ struct type_info {
  /* True if there is no multiple inheritance in this type's inheritance tree */
  bool simple_ancestors : 1;
  /* for base vs derived holder_type checks */
+ // SMART_HOLDER_BAKEIN_FOLLOW_ON: Remove default_holder member here and
+ // produce better error messages in the places where it is currently used.
  bool default_holder : 1;
  /* true if this is a type registered with py::module_local */
  bool module_local : 1;
+#ifdef PYBIND11_HAVE_INTERNALS_WITH_SMART_HOLDER_SUPPORT
+ holder_enum_t holder_enum_v = holder_enum_t::undefined;
+#endif
 };
 
 /// On MSVC, debug and release builds are not ABI-compatible!
@@ -322,25 +342,15 @@ struct type_info {
 # define PYBIND11_INTERNALS_KIND ""
 #endif
 
-/// See README_smart_holder.rst:
-/// Classic / Conservative / Progressive cross-module compatibility
-#ifndef PYBIND11_INTERNALS_SH_DEF
-# if defined(PYBIND11_USE_SMART_HOLDER_AS_DEFAULT)
-# define PYBIND11_INTERNALS_SH_DEF "_sh_def"
-# else
-# define PYBIND11_INTERNALS_SH_DEF ""
-# endif
-#endif
-
 #define PYBIND11_INTERNALS_ID \
  "__pybind11_internals_v" PYBIND11_TOSTRING(PYBIND11_INTERNALS_VERSION) \
- PYBIND11_INTERNALS_KIND PYBIND11_COMPILER_TYPE PYBIND11_STDLIB PYBIND11_BUILD_ABI \
- PYBIND11_BUILD_TYPE PYBIND11_INTERNALS_SH_DEF "__"
+ PYBIND11_INTERNALS_KIND PYBIND11_COMPILER_TYPE PYBIND11_STDLIB   \
+ PYBIND11_BUILD_ABI PYBIND11_BUILD_TYPE "__"
 
 #define PYBIND11_MODULE_LOCAL_ID \
  "__pybind11_module_local_v" PYBIND11_TOSTRING(PYBIND11_INTERNALS_VERSION) \
- PYBIND11_INTERNALS_KIND PYBIND11_COMPILER_TYPE PYBIND11_STDLIB PYBIND11_BUILD_ABI \
- PYBIND11_BUILD_TYPE PYBIND11_INTERNALS_SH_DEF "__"
+ PYBIND11_INTERNALS_KIND PYBIND11_COMPILER_TYPE PYBIND11_STDLIB   \
+ PYBIND11_BUILD_ABI PYBIND11_BUILD_TYPE "__"
 
 /// Each module locally stores a pointer to the `internals` data. The data
 /// itself is shared among modules with the same `PYBIND11_INTERNALS_ID`.