Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address regression introduced in #5381 #5396

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Address regression introduced in #5381 #5396

wants to merge 19 commits into from
+43 −3

Commits on Oct 5, 2024

  1. Incomplete attempt to address regression introduced in pybind#5381

    @francesco-ballarin
    francesco-ballarin committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    8cf1cdb View commit details
    Browse the repository at this point in the history

  2. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    9d107d2 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Revert "style: pre-commit fixes" 

    This reverts commit 9d107d2.
    @francesco-ballarin
    francesco-ballarin committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    b508a07 View commit details
    Browse the repository at this point in the history

  2. Revert "Incomplete attempt to address regression introduced in pybind… 

    …#5381"

This reverts commit 8cf1cdb.
    @francesco-ballarin
    francesco-ballarin committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    95e0325 View commit details
    Browse the repository at this point in the history

  3. Simpler fix for the regression introduced in pybind#5381

    @francesco-ballarin
    francesco-ballarin committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    8cbca65 View commit details
    Browse the repository at this point in the history

  4. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    4c87a23 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Added if constexpr workaround 

    This can probably be done better but at least this is a start.
    @gentlegiantJGC
    gentlegiantJGC committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b375ad7 View commit details
    Browse the repository at this point in the history

  2. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    56758c7 View commit details
    Browse the repository at this point in the history

  3. Replace if constexpr with template struct 

    if constexpr was not added until C++ 17.
I think this should do the same thing as before.
    @gentlegiantJGC
    gentlegiantJGC committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e55e864 View commit details
    Browse the repository at this point in the history

  4. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    badb28d View commit details
    Browse the repository at this point in the history

  5. Made comment clearer

    @gentlegiantJGC
    gentlegiantJGC committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6494448 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Added test cases

    @gentlegiantJGC
    gentlegiantJGC committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    84cd376 View commit details
    Browse the repository at this point in the history

  2. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    1c845cf View commit details
    Browse the repository at this point in the history

  3. Fixed is_same_or_base_of reference

    @gentlegiantJGC
    gentlegiantJGC committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    5965a65 View commit details
    Browse the repository at this point in the history

  4. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    add8277 View commit details
    Browse the repository at this point in the history

  5. Added static assert messages

    @gentlegiantJGC
    gentlegiantJGC committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    c4ce357 View commit details
    Browse the repository at this point in the history

  6. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    8b9e5d1 View commit details
    Browse the repository at this point in the history

  7. Replaced typedef with using

    @gentlegiantJGC
    gentlegiantJGC committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    ccb165b View commit details
    Browse the repository at this point in the history

  8. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    8bc767d View commit details
    Browse the repository at this point in the history