Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove ruff ignore E501 #5539

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Feb 21, 2025

Description

With PR #4912 we removed black:

-# Black, the code formatter, natively supports pre-commit
-- repo: https://github.com/psf/black-pre-commit-mirror
-  rev: "23.10.1" # Keep in sync with blacken-docs
-  hooks:
-  - id: black

So this isn't true anymore:

"E501", # Line too long (Black is enough)

I tried to remove that line, but it doesn't make a difference, ruff doesn't produce the E501 error. See dummy test case, which doesn't trigger any ruff errors.

It would be nice to see that error, even if we need to fix manually.

@henryiii: Do you happen to know what suppresses the E501?

Suggested changelog entry:

@timohl
Copy link
Contributor

timohl commented Feb 21, 2025

As far as I can see, Ruff does not include E501 by default, so it has to be added to extend-select.
See docs.astral.sh/ruff/configuration for the default settings:
Only "E4", "E7", "E9" are in select but not E5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants