Skip to content

Fix PyObject_HasAttrString checking #5928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cyyever wants to merge 3 commits into from
+6 −1
Closed

Fix PyObject_HasAttrString checking #5928

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
229b3bc
Fix PyObject_HasAttrString return value
cyyever Dec 9, 2025
b909a5d
Merge branch 'master' into cyyever→fix2
rwgk Dec 13, 2025
1d1f343
[skip ci] Handle PyObject_HasAttrString error when probing __notes__
rwgk Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion include/pybind11/pytypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,8 +547,13 @@ struct error_fetch_and_normalize {
// The presence of __notes__ is likely due to exception normalization
// errors, although that is not necessarily true, therefore insert a
// hint only:
if (PyObject_HasAttrString(m_value.ptr(), "__notes__") != 0) {
const int has_notes = PyObject_HasAttrString(m_value.ptr(), "__notes__");
if (has_notes == 1) {
m_lazy_error_string += "[WITH __notes__]";
} else if (has_notes == -1) {
// Ignore secondary errors when probing for __notes__ to avoid leaking a
// spurious exception while still reporting the original error.
PyErr_Clear();
}
#else
// PyErr_NormalizeException() may change the exception type if there are cascading
Expand Down