Add CMake support #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dependencies of Bazel as much as possible.
This reverts commit cef78f6.
* Test include file exporting * Fix target_include_directories * Move to canonical include_dirs. Trying w/o install since no install command is present * Move include dir one level up * Add var to get include dir right * All exported targets now have include_dirs set
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 11, 2023
Observed while locally testing #7: ``` In file included from /usr/local/google/home/rwgk/forked/pybind11_abseil/pybind11_abseil/tests/absl_example.cc:23: /usr/local/google/home/rwgk/forked/pybind11_abseil/pybind11_abseil/absl_casters.h: In member function ‘bool pybind11::detail::type_caster<absl::lts_20211102::Duration>::load(pybind11::handle, bool)’: /usr/local/google/home/rwgk/forked/pybind11_abseil/pybind11_abseil/absl_casters.h:194:48: warning: ‘bool pybind11::handle::operator==(const pybind11::handle&) const’ is deprecated: Use obj1.is(obj2) instead [-Wdeprecated-declarations] 194 | if (src == object(py_duration_t.attr("max"))) { | ^ In file included from /usr/local/google/home/rwgk/forked/pybind11_abseil/tmp_build/_deps/pybind11-src/include/pybind11/detail/type_caster_base.h:12, from /usr/local/google/home/rwgk/forked/pybind11_abseil/tmp_build/_deps/pybind11-src/include/pybind11/cast.h:15, from /usr/local/google/home/rwgk/forked/pybind11_abseil/tmp_build/_deps/pybind11-src/include/pybind11/attr.h:14, from /usr/local/google/home/rwgk/forked/pybind11_abseil/tmp_build/_deps/pybind11-src/include/pybind11/detail/class.h:1, from /usr/local/google/home/rwgk/forked/pybind11_abseil/tmp_build/_deps/pybind11-src/include/pybind11/pybind11.h:13, from /usr/local/google/home/rwgk/forked/pybind11_abseil/tmp_build/_deps/pybind11-src/include/pybind11/complex.h:12, from /usr/local/google/home/rwgk/forked/pybind11_abseil/pybind11_abseil/tests/absl_example.cc:6: /usr/local/google/home/rwgk/forked/pybind11_abseil/tmp_build/_deps/pybind11-src/include/pybind11/pytypes.h:290:10: note: declared here 290 | bool operator==(const handle &h) const { return m_ptr == h.m_ptr; } | ^~~~~~~~ ``` PiperOrigin-RevId: 555974032
copybara-service bot
pushed a commit
to pybind/pybind11_protobuf
that referenced
this pull request
Aug 11, 2023
…e-commit-config.yaml This is to help with whitespace cleanup in the cmake files currently under development under pybind/pybind11_abseil#7 PiperOrigin-RevId: 556012790
copybara-service bot
pushed a commit
to pybind/pybind11_protobuf
that referenced
this pull request
Aug 11, 2023
…e-commit-config.yaml This is to help with whitespace cleanup in the cmake files currently under development under pybind/pybind11_abseil#7 PiperOrigin-RevId: 556012790
copybara-service bot
pushed a commit
to pybind/pybind11_protobuf
that referenced
this pull request
Aug 11, 2023
…e-commit-config.yaml This is to help with whitespace cleanup in the cmake files currently under development under pybind/pybind11_abseil#7 PiperOrigin-RevId: 556026304
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 11, 2023
…e-commit-config.yaml This is to help with whitespace cleanup in the cmake files currently under development under #7 PiperOrigin-RevId: 556026304
added 2 commits
August 11, 2023 15:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Cmake support. Tried to match the object names and dependencies of Bazel as much as possible.
To use:
Ensure CMake 3.11 or later is installed
Navigate to top-level directory
mkdir build; cd build; cmake ../; make; make testThis will build (and download all dependencies) and run all tests.