Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require CMake 3.5 of higher #65

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Require CMake 3.5 of higher #65

merged 1 commit into from
Mar 6, 2024

Conversation

mlund
Copy link
Contributor

@mlund mlund commented Mar 5, 2024

This fixes the deprecation warning as reported in #64

@mlund
Require CMake 3.5 of higher
91691e9 
This fixes the deprecation warning as reported in pybind#64
@martinRenou
Copy link
Collaborator

Thanks for the PR!

We should probably update the tests to not test against 3.7 anymore (end of life was June 27, 2023). But test against 3.11 and 3.12.

martinRenou
martinRenou approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do that separately and ignore the 3.7 failure for now as it's very well not related to your changes.

Thanks again!

@martinRenou martinRenou merged commit 0036b4a into pybind:master Mar 6, 2024
11 of 12 checks passed
@martinRenou martinRenou mentioned this pull request Mar 6, 2024
Closed
@mlund mlund deleted the patch-1 branch March 7, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlund @martinRenou