review media upload and thumbnail upload

[nebukadhezer]

Hey Toke,

this contains:

• thumbnail upload and propagation to parents
• review media upload
• task overrides per component

Cheers
Johannes

[tokejepsen]

Uploading review media is already supported by making the correctly named components with metadata and location. I would like to keep the code as open as possible, and let the developers determine workflows on how to upload media. For this reason I would remove this code about uploading review media, unless you have some user case you want to support?

[nebukadhezer]

Right, I should give that a try :-)

[tokejepsen]

Hey @nebukadhezer,

Thank you for this PR :)

1. When propagating the thumbnail to the parents, does it propagate all the way to the top of the hierarchy ei. the project?
2. What is the use case for the "task overrides per component"? Could you link to a different task when specifying the assetversion_data?

[nebukadhezer]

1. yes it could
2. Right again I can specify the task overrides in asset_data and assetversion_data

[tokejepsen]

yes it could

What is the default behavior for it? Does it always propagate to the top of the hierarchy?

[nebukadhezer]

You add a thumb by specifiying
"thumbnail_path": "/path/to/jpg"
and via egg:
"propagate_thumb_to_parents": 2
The thumb would be set to the AssetVersion, the Task and the parent of the Task (a Shot most likely...)

If "propagate_thumb_to_parents" is not specified the thumb is for the assetVersion only.

we can use True for 1 and False for 0 or just an int above 1 to propagate through to the number of parents

• 1 is the task where the asset version is linked to
• 2 would be the parent of the task
• 3 would be the parent of the parent of the task and so on

[nebukadhezer]

one more idea
https://gist.github.com/nebukadhezer/271dc7bc178666ee357b12861f335ec8#file-ftrack_integrator-py-L148
When a component is overwritten we update the user and the date too...
Currently we get the ftrack user from our context object but we could query for the user too ?!
What do you think should I make a seperate PR for that ?

[tokejepsen]

When a component is overwritten we update the user and the date too...
Currently we get the ftrack user from our context object but we could query for the user too ?!
What do you think should I make a seperate PR for that ?

That is a very good idea!
Yeah, a separate PR would be best, please.

[tokejepsen]

You add a thumb by specifiying
"thumbnail_path": "/path/to/jpg"

Currently this is done with a True/False flag: #61

we can use True for 1 and False for 0 or just an int above 1 to propagate through to the number of parents

Sure, I like have a single int value. I would maybe reduce the name length to propagate_thumbnail.

[nebukadhezer]

hey
totally lost track here... can we merge this ?

[tokejepsen]

The code looks good to me, but could you clean up the existing thumbnail behaviour?

pyblish-ftrack/pyblish_ftrack/plugins/integrate_ftrack_api.py

Line 274 in 5dcd1ee

# Setting assetversion thumbnail

Also some documentation for this would be great.