Work in progress of new ID-based items #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a ton. Is it mainly test changes from this point? |
|
Will have a quick look on my end with this. |
Possibly, but we're probably not out of the woods yet. The tests might reveal a flaw somehow. |
|
It was purely on IDs <-> names, not something else. See my PR. Ran the version from that PR through a quick scene as well and seems to work (just quickly tested) including the actions. |
Continuing on from PR to pyblish/pyblish-qml pyblish#181
Fix failing tests (and update from pyblish repo for `ping` method)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GUI works, but some tests fail!