Fix state machine transition bug from PR #304 #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User operation will not be able to continue if the validation failed during the publish, since the logic to interrupt publish when validation failed is taking place in the beginning of extraction. In the state machine, `extracting` state will need to transition to `finished` when the validation failed, and since it's not able to do so, operation can't continue, due to the stop button didn't change to reset button. This commit fixed that.
|
Fantastic work @davidlatwe, you are welcome to merge! |
|
Thanks, merging ! ❤️ |
davidlatwe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the state machine,
extractingstate needs to transition tofinishedif the validation failed during the publish, or the stop button won't change to reset button, and cause user operation not able to continue.This commit fixed that.
Somehow I missed this one in the previous tests, after founding this bug in my work, right after the release of
1.8.6, I spend a day did a series of user operation flow inspection, including each kind ofAction, and compared the outcome with previous releases, so far this is the only one that I have missed based on previous PRs.