Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 309 #314

Merged
merged 4 commits into from
Jan 17, 2019
Merged

Fix 309 #314

merged 4 commits into from
Jan 17, 2019

Conversation

davidlatwe
Copy link
Collaborator

This PR will fix #309 , and UX bug related to #281 but on plugin section.

Before

qml_309

  • The instance Batman and David should not be toggled, but the restriction got bypassed via toggling the section.
  • Plugin checkbox did not give immediate respond to section toggling.

After

qml_309fix

  • All fixed !

Implementation

  1. Collect all optional items' state.
  2. Override section state if all optional items are in the same state. This guaranteed the optional item be able to respond to every toggle.
  3. Set check state.

@mottosso
Copy link
Member

Nice work! Could you increment the version too? Then I'll make a new release for it.

@davidlatwe
Copy link
Collaborator Author

Done !

@BigRoy
Copy link
Member

BigRoy commented Jan 13, 2019

Good stuff again David! 👍

@tokejepsen
Copy link
Member

Awesome work @davidlatwe

@davidlatwe
Copy link
Collaborator Author

Thanks :)
Merging this, and pinging @mottosso for release :P

@davidlatwe davidlatwe merged commit 5860378 into pyblish:master Jan 17, 2019
@davidlatwe davidlatwe deleted the fix-309 branch January 17, 2019 07:45
@mottosso
Copy link
Member

Yes, that is all fine! :)

One question though, that I noticed elsewhere as well, how come the instances are green, and yet checkable? :O I thought they were green only after having been processed, at which point they would not be checkable anymore?

@mottosso
Copy link
Member

Oh and I remembered you are able to make releases too, you are most welcome to do that here as well!

@davidlatwe
Copy link
Collaborator Author

how come the instances are green, and yet checkable?

The reason it's green is that there's a plugin printing log message for every instances in collecting phase.

class ListHeros(pyblish.api.InstancePlugin):
    order = pyblish.api.CollectorOrder + 0.1

    def process(self, instance):
        self.log.info(instance)

So yeah, they did been processed :)

at which point they would not be checkable anymore?

I intentionally set data["optional"] = False to some instances at their creation, for the example ;D

Oh and I remembered you are able to make releases too

Haha, thanks :D

@BigRoy
Copy link
Member

BigRoy commented Jan 17, 2019

One question though, that I noticed elsewhere as well, how come the instances are green, and yet checkable? :O I thought they were green only after having been processed, at which point they would not be checkable anymore?

AND

The reason it's green is that there's a plugin printing log message for every instances in collecting phase.

Is this related to #283?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggling family groups does not respect mandatory Instances
4 participants