Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Module not found #28

Closed
NicolaCourtier opened this issue Sep 10, 2023 · 0 comments · Fixed by #29
Closed

[Bug]: Module not found #28

NicolaCourtier opened this issue Sep 10, 2023 · 0 comments · Fixed by #29
Assignees
@NicolaCourtier
Labels
bug Something isn't working

Comments

@NicolaCourtier
Copy link
Member

Python Version

3.11.5

Describe the bug

Not all scripts are imported when pip install-ing PyBOP. The python scripts located inside subfolders, such as optimisation, cannot be seen without an __init__.py file in their location.

Steps to reproduce the behaviour

pyenv virtualenv 3.11.5 pybop-env

pyenv activate pybop-env

pip install pybamm

pip install git+https://github.com/pybop-team/PyBOP

python "PATH TO/test_parameterisation.py"

Relevant log output

ModuleNotFoundError: No module named 'pybop.optimisation'
@NicolaCourtier NicolaCourtier added the bug Something isn't working label Sep 10, 2023
@NicolaCourtier NicolaCourtier self-assigned this Sep 10, 2023
@NicolaCourtier NicolaCourtier linked a pull request Sep 10, 2023 that will close this issue
Add init py files #29
Merged
BradyPlanden added a commit that referenced this issue Sep 13, 2023
@BradyPlanden
__init__.py bugfix for #28
01956aa
BradyPlanden added a commit that referenced this issue Sep 14, 2023
@BradyPlanden
Alignment for #28, fix build error
6d20181
NicolaCourtier added a commit that referenced this issue Sep 14, 2023
@NicolaCourtier
Merge pull request #35 from pybop-team/develop
0d89b26 
Alignment for #28, fix build error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NicolaCourtier NicolaCourtier

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add init py files pybop-team/PyBOP
1 participant
@NicolaCourtier