Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code restructure for improved modularity #54

Closed
NicolaCourtier opened this issue Oct 13, 2023 · 0 comments · Fixed by #80
Closed

Code restructure for improved modularity #54

NicolaCourtier opened this issue Oct 13, 2023 · 0 comments · Fixed by #80
Assignees
@NicolaCourtier
Labels
blocker An issue which must be resolved before work can resume on other issues.

Comments

@NicolaCourtier
Copy link
Member

Restructure the code into component classes in which the cost function and optimisation method can be changed in isolation from one another.
@NicolaCourtier NicolaCourtier self-assigned this Oct 13, 2023
@NicolaCourtier NicolaCourtier added the blocker An issue which must be resolved before work can resume on other issues. label Oct 13, 2023
@NicolaCourtier NicolaCourtier linked a pull request Oct 16, 2023 that will close this issue
Restructure for improved modularity #60
Closed
@NicolaCourtier NicolaCourtier mentioned this issue Oct 16, 2023
Closed
BradyPlanden added a commit that referenced this issue Oct 31, 2023
@BradyPlanden
Squashed merge of #54
0f91bab
BradyPlanden added a commit that referenced this issue Oct 31, 2023
@BradyPlanden
Squashed commit of #54 - optimisation.py changes & dependancies
a6e59b0
BradyPlanden added a commit that referenced this issue Nov 1, 2023
@BradyPlanden
Squashed commit of #54 - Add Optimisers
e4e161d
@BradyPlanden BradyPlanden mentioned this issue Nov 2, 2023
Merged
BradyPlanden added a commit that referenced this issue Nov 3, 2023
@BradyPlanden
Merge pull request #80 from pybop-team/72-54-restructure-and-add-pint…
e77c5a2 
…s-optimisation-methods

Restructure and initial Pints implementation (#54) & (#72)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NicolaCourtier NicolaCourtier

Labels
blocker An issue which must be resolved before work can resume on other issues.
Projects
None yet
Milestone
No milestone
2 participants
@NicolaCourtier @BradyPlanden