-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Problem into Base, Fitting and Design #125
Conversation
Pull latest from develop
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #125 +/- ##
===========================================
+ Coverage 90.57% 92.24% +1.67%
===========================================
Files 18 30 +12
Lines 647 1057 +410
===========================================
+ Hits 586 975 +389
- Misses 61 82 +21 ☔ View full report in Codecov by Sentry. |
Hi @NicolaCourtier, nice one! How do you feel about changing |
It's looking good @NicolaCourtier! I've left few comments above, can you update the CHANGELOG.md as well? |
Thanks for the review @BradyPlanden! I've acted on your feedback so it would be great if you could take another look at the latest version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @NicolaCourtier, thanks for the great contribution! I left a few comments, but looks really good overall!
An initial PR to restructure Problem ahead of adding a design optimisation example.