Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Problem into Base, Fitting and Design #125

Merged
merged 14 commits into from
Dec 4, 2023

Conversation

NicolaCourtier
Copy link
Member

An initial PR to restructure Problem ahead of adding a design optimisation example.

@NicolaCourtier NicolaCourtier linked an issue Nov 28, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5225cfc) 90.57% compared to head (f46fa6f) 92.24%.
Report is 22 commits behind head on develop.

Files Patch % Lines
pybop/_problem.py 97.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #125      +/-   ##
===========================================
+ Coverage    90.57%   92.24%   +1.67%     
===========================================
  Files           18       30      +12     
  Lines          647     1057     +410     
===========================================
+ Hits           586      975     +389     
- Misses          61       82      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden
Copy link
Member

Hi @NicolaCourtier, nice one! How do you feel about changing FittingProblem to FitProblem?

@BradyPlanden
Copy link
Member

It's looking good @NicolaCourtier! I've left few comments above, can you update the CHANGELOG.md as well?

@NicolaCourtier
Copy link
Member Author

Thanks for the review @BradyPlanden! I've acted on your feedback so it would be great if you could take another look at the latest version.

Copy link
Member

@BradyPlanden BradyPlanden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @NicolaCourtier, thanks for the great contribution! I left a few comments, but looks really good overall!

@NicolaCourtier NicolaCourtier merged commit a14af1f into develop Dec 4, 2023
@NicolaCourtier NicolaCourtier deleted the 38-design-example branch December 4, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add design optimisation example
2 participants