-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformat signal into a list #147
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #147 +/- ##
===========================================
+ Coverage 93.03% 93.41% +0.37%
===========================================
Files 34 34
Lines 1178 1199 +21
===========================================
+ Hits 1096 1120 +24
+ Misses 82 79 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Nicola! I've added some comments to take a look at, hopefully they are helpful. Overall, great contribution 👍
Thanks very much for the review @BradyPlanden! It would be great if you could double check the 3 conversations above and either add more info or mark as resolved. |
Dataset
contain a dictionarysignal
into a list of stringsset_max_iterations
test_spm_optimisers
and addtest_multiple_signals