Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat signal into a list #147

Merged
merged 18 commits into from
Dec 14, 2023
Merged

Reformat signal into a list #147

merged 18 commits into from
Dec 14, 2023

Conversation

NicolaCourtier
Copy link
Member

  • Make Dataset contain a dictionary
  • Extend signal into a list of strings
  • Align NLopt and SciPy optimisers with set_max_iterations
  • Parameterise test_spm_optimisers and add test_multiple_signals
  • Update Changelog

@NicolaCourtier NicolaCourtier linked an issue Dec 14, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a0d44e5) 93.03% compared to head (ca63085) 93.41%.
Report is 8 commits behind head on develop.

Files Patch % Lines
pybop/_problem.py 93.10% 2 Missing ⚠️
pybop/optimisers/nlopt_optimize.py 66.66% 1 Missing ⚠️
pybop/optimisers/scipy_optimisers.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #147      +/-   ##
===========================================
+ Coverage    93.03%   93.41%   +0.37%     
===========================================
  Files           34       34              
  Lines         1178     1199      +21     
===========================================
+ Hits          1096     1120      +24     
+ Misses          82       79       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@BradyPlanden BradyPlanden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Nicola! I've added some comments to take a look at, hopefully they are helpful. Overall, great contribution 👍

pybop/_problem.py Show resolved Hide resolved
pybop/_problem.py Outdated Show resolved Hide resolved
pybop/_problem.py Outdated Show resolved Hide resolved
pybop/_problem.py Show resolved Hide resolved
pybop/models/base_model.py Outdated Show resolved Hide resolved
pybop/optimisers/scipy_optimisers.py Show resolved Hide resolved
tests/unit/test_parameterisations.py Outdated Show resolved Hide resolved
tests/unit/test_parameterisations.py Show resolved Hide resolved
pybop/plotting/quick_plot.py Show resolved Hide resolved
pybop/models/base_model.py Show resolved Hide resolved
@NicolaCourtier
Copy link
Member Author

Thanks very much for the review @BradyPlanden! It would be great if you could double check the 3 conversations above and either add more info or mark as resolved.

@NicolaCourtier NicolaCourtier merged commit 14881c3 into develop Dec 14, 2023
18 checks passed
@NicolaCourtier NicolaCourtier deleted the 145-multiple-signals branch December 14, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiple signals
2 participants