Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes failing observer tests #197

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Fixes failing observer tests #197

merged 2 commits into from
Feb 13, 2024

Conversation

BradyPlanden
Copy link
Member

Adds:

  • Longer simulation signal
  • Initial SOC = 1.0
  • Flips location for higher cost to reduce likelihood of simulation hitting an end condition

martinjrobins
martinjrobins approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks @BradyPlanden

@martinjrobins martinjrobins merged commit 5e6c73c into 187-add-m-series-github-runners-to-tests Feb 13, 2024
17 checks passed
@martinjrobins martinjrobins deleted the 196-bug-observer-tests-fail-on-m-series-hardware-macos-140 branch February 13, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinjrobins martinjrobins martinjrobins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BradyPlanden @martinjrobins