-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.12 #209
Add Python 3.12 #209
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #209 +/- ##
========================================
Coverage 94.58% 94.58%
========================================
Files 44 44
Lines 1829 1829
========================================
Hits 1730 1730
Misses 99 99 ☔ View full report in Codecov by Sentry. |
As previously discussed, it looks like |
An initial thought would be adding something like this:
and calling it within the matrix construction loop. However, I'm open better methods if available! Edit: Implemented the above, scheduled tests have ran here: https://github.com/pybop-team/PyBOP/actions/runs/7974984340 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @BradyPlanden – looks great! I have two small comments, feel free to merge when it's ready.
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Closes #206.