-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release workflow #215
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #215 +/- ##
========================================
Coverage 94.29% 94.29%
========================================
Files 32 32
Lines 1614 1614
========================================
Hits 1522 1522
Misses 92 92 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BradyPlanden, I have read through this and can approve with two comments. I would suggest adding a condition to stop the publish
job from being run on forks, for security reasons, just in case.
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
This adds:
Once this is merged, I think we can create a release candidate for
v24.2
.