Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release workflow #215

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Update release workflow #215

merged 6 commits into from
Feb 23, 2024

Conversation

BradyPlanden
Copy link
Member

@BradyPlanden BradyPlanden commented Feb 23, 2024

This adds:

  • A release_workflow.md to clarify the release steps and workflow
  • Updates the release_action.yaml for trusted publishing.

Once this is merged, I think we can create a release candidate for v24.2.

@BradyPlanden BradyPlanden linked an issue Feb 23, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (29c6ff2) to head (8f3d66b).
Report is 1 commits behind head on develop.

❗ Current head 8f3d66b differs from pull request most recent head 1d9e190. Consider uploading reports for the commit 1d9e190 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #215   +/-   ##
========================================
  Coverage    94.29%   94.29%           
========================================
  Files           32       32           
  Lines         1614     1614           
========================================
  Hits          1522     1522           
  Misses          92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BradyPlanden, I have read through this and can approve with two comments. I would suggest adding a condition to stop the publish job from being run on forks, for security reasons, just in case.

.github/release_workflow.md Outdated Show resolved Hide resolved
.github/workflows/release_action.yaml Outdated Show resolved Hide resolved
@BradyPlanden BradyPlanden merged commit 188ebb4 into develop Feb 23, 2024
28 of 29 checks passed
@BradyPlanden BradyPlanden deleted the 157-add-release_workflowmd branch February 23, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add release_workflow.md
2 participants