-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Base Likelihoods, Maximum Likelihood Example #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efinition, add probablilitybased cost function, Add MLE example
Closed
3 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #218 +/- ##
===========================================
- Coverage 94.34% 94.29% -0.05%
===========================================
Files 32 33 +1
Lines 1661 1753 +92
===========================================
+ Hits 1567 1653 +86
- Misses 94 100 +6 ☔ View full report in Codecov by Sentry. |
NicolaCourtier
approved these changes
Mar 8, 2024
* Move _likelihoods.py to /costs * Make BaseLikelihood a type of cost * Update test_cost * Update n_parameters to _n_parameters * Move n_parameters property * Change _minimising to Boolean * Update _likelihoods.py
… __init__ variables from baselikelihood, updt basecost to align with baselikelihood args
…itions, small bugfixes to basecost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
min_iterations
Closes #210.