Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Base Likelihoods, Maximum Likelihood Example #218

Merged
merged 11 commits into from
Mar 8, 2024

Conversation

BradyPlanden
Copy link
Member

@BradyPlanden BradyPlanden commented Feb 26, 2024

This PR adds:

  • A base likelihood class
  • Gaussian Likelihoods with known and unknown sigma values (initially based on Pints')
  • Updates the optimisation class for likelihood definitions and min_iterations
  • A probablility based cost function to return the negative log likelihoods
  • A MLE example
  • Tests for coverage

Closes #210.

…efinition, add probablilitybased cost function, Add MLE example
@BradyPlanden BradyPlanden linked an issue Feb 26, 2024 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 91.81818% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 94.29%. Comparing base (02ee2e2) to head (13309fb).
Report is 1 commits behind head on develop.

Files Patch % Lines
pybop/costs/_likelihoods.py 89.55% 7 Missing ⚠️
pybop/costs/fitting_costs.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #218      +/-   ##
===========================================
- Coverage    94.34%   94.29%   -0.05%     
===========================================
  Files           32       33       +1     
  Lines         1661     1753      +92     
===========================================
+ Hits          1567     1653      +86     
- Misses          94      100       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden BradyPlanden mentioned this pull request Feb 26, 2024
5 tasks
BradyPlanden and others added 4 commits March 8, 2024 15:05
* Move _likelihoods.py to /costs

* Make BaseLikelihood a type of cost

* Update test_cost

* Update n_parameters to _n_parameters

* Move n_parameters property

* Change _minimising to Boolean

* Update _likelihoods.py
… __init__ variables from baselikelihood, updt basecost to align with baselikelihood args
@BradyPlanden BradyPlanden merged commit da016b4 into develop Mar 8, 2024
29 of 31 checks passed
@BradyPlanden BradyPlanden deleted the 210-add-likelihood-classes branch March 8, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add likelihood classes
2 participants