Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: benchmark solution tracking #243

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

BradyPlanden
Copy link
Member

@BradyPlanden BradyPlanden commented Mar 19, 2024

The benchmarks are currently failing since the object returned from track_parameterisation is of type tuple. asv only supports single element objects, so this change updates the track methods to track each element separately.

To minimise the number of times the benchmark is ran, I've split the benchmark into separate timing and tracking classes. This split minimizes the number of times the parameterisation benchmark is ran, unfortunately three times seems to be the minimum (time_parameterisation, track_x1, and track_x2) as asv doesn't support vector/list objects.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.30%. Comparing base (a7979c4) to head (e1c78d5).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #243   +/-   ##
========================================
  Coverage    94.30%   94.30%           
========================================
  Files           33       33           
  Lines         1757     1757           
========================================
  Hits          1657     1657           
  Misses         100      100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not fully sure I follow what is going on, but I think it makes sense. We could split up the benchmarks into two parallel CI jobs too if they are taking too much time right now.

@BradyPlanden
Copy link
Member Author

Thanks for the review, for reference I've updated the original comment to be more descriptive of the problem. Unfortunately, I haven't found a way to track the optimisation output of our methods and time them at the same time.

@BradyPlanden BradyPlanden merged commit 896f1b3 into develop Mar 19, 2024
31 checks passed
@BradyPlanden BradyPlanden deleted the patch-benchmarks branch March 19, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants