Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template & notebooks #270

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Update PR template & notebooks #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae17245
Updt PR template for examples, nox session typo
BradyPlanden Apr 4, 2024
87cbf1c
Updt notebooks
BradyPlanden Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Before you mark your PR as ready for review, please ensure that you've considere
## Type of change
- [ ] New Feature: A non-breaking change that adds new functionality.
- [ ] Optimization: A code change that improves performance.
- [ ] Examples: A change to existing or additional examples.
- [ ] Bug Fix: A non-breaking change that addresses an issue.
- [ ] Documentation: Updates to documentation or new documentation for new features.
- [ ] Refactoring: Non-functional changes that improve the codebase.
Expand All @@ -24,7 +25,7 @@ Before you mark your PR as ready for review, please ensure that you've considere

- [ ] No style issues: `$ pre-commit run` (or `$ nox -s pre-commit`) (see [CONTRIBUTING.md](https://github.com/pybop-team/PyBOP/blob/develop/CONTRIBUTING.md#installing-and-using-pre-commit) for how to set this up to run automatically when committing locally, in just two lines of code)
- [ ] All unit tests pass: `$ nox -s tests`
- [ ] The documentation builds: `$ nox -s docs`
- [ ] The documentation builds: `$ nox -s doctest`

You can run integration tests, unit tests, and doctests together at once, using `$ nox -s quick`.

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

## Bug Fixes

- [#270](https://github.com/pybop-team/PyBOP/pull/270) - Updates PR template.
- [#91](https://github.com/pybop-team/PyBOP/issues/91) - Adds a check on the number of parameters for CMAES and makes XNES the default optimiser.

# [v24.3](https://github.com/pybop-team/PyBOP/tree/v24.3) - 2024-03-25
Expand Down
201 changes: 158 additions & 43 deletions examples/notebooks/equivalent_circuit_identification.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

177 changes: 145 additions & 32 deletions examples/notebooks/spm_Adam.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

170 changes: 138 additions & 32 deletions examples/notebooks/spm_CMAES.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

91 changes: 82 additions & 9 deletions examples/notebooks/spm_electrode_design.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

170 changes: 138 additions & 32 deletions examples/notebooks/spm_scipy_DifferentialEvolution.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

Loading