-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates README, adds additional notebooks, bugfixes to model.simulateS1
#293
Merged
BradyPlanden
merged 17 commits into
develop
from
288-add-intelligent-eu-project-as-funding-contributor
Apr 22, 2024
Merged
Updates README, adds additional notebooks, bugfixes to model.simulateS1
#293
BradyPlanden
merged 17 commits into
develop
from
288-add-intelligent-eu-project-as-funding-contributor
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…timiser notebook, fixes bug in model.simulateS1 when simulate fails
…-nbmake max cell timeout
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #293 +/- ##
========================================
Coverage 95.49% 95.49%
========================================
Files 38 38
Lines 2040 2040
========================================
Hits 1948 1948
Misses 92 92 ☔ View full report in Codecov by Sentry. |
NicolaCourtier
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the README to the current state of the project with example links and supported methods. It also adds the following notebooks:
Finally, it fixes an bug within the
model.simulateS1
method which returned the wrong object type when the forward model failed.Issue reference
Fixes #288
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.