-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Minkowski and SumofPower Cost #383
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #383 +/- ##
===========================================
+ Coverage 97.88% 98.02% +0.14%
===========================================
Files 43 43
Lines 2598 2632 +34
===========================================
+ Hits 2543 2580 +37
+ Misses 55 52 -3 ☔ View full report in Codecov by Sentry. |
eae7d67
to
43cfcb5
Compare
…ze, refactor docstring / inf_count
…meterisation's max_unchanged_iterations setting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BradyPlanden, a few comments for you to go through, but overall it's looking good. I'll just upload some minor edits to the text of the example notebook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @BradyPlanden !
Description
This PR adds an implementation of Minkowski Loss, with tests and example usage.
Issue reference
Fixes #382
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.