-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge model build and rebuild #451
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #451 +/- ##
===========================================
+ Coverage 98.51% 98.67% +0.16%
===========================================
Files 46 46
Lines 2960 2941 -19
===========================================
- Hits 2916 2902 -14
+ Misses 44 39 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a nice refactor, thanks @NicolaCourtier. A few suggestions for you to consider.
Co-authored-by: Brady Planden <55357039+BradyPlanden@users.noreply.github.com>
Description
Refactor BaseModel so that rebuilding the model uses the same build functionality as building from scratch.
Issue reference
Fixes #444
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.