Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bound prior sampling (#69) #70

Conversation

BradyPlanden
Copy link
Member

@BradyPlanden BradyPlanden commented Oct 26, 2023

This PR applies boundary constraints on the prior sampling with corresponding tests. A small bugfix in the parameterisations tests was applied as well. Closes #69.

@BradyPlanden BradyPlanden linked an issue Oct 26, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #70 (fbde169) into develop (346931f) will increase coverage by 0.19%.
The diff coverage is 96.15%.

@@             Coverage Diff             @@
##           develop      #70      +/-   ##
===========================================
+ Coverage    90.01%   90.21%   +0.19%     
===========================================
  Files           28       29       +1     
  Lines          731      756      +25     
===========================================
+ Hits           658      682      +24     
- Misses          73       74       +1     
Files Coverage Δ
pybop/optimisation.py 94.44% <100.00%> (ø)
tests/unit/test_optimisation.py 100.00% <100.00%> (ø)
pybop/parameters/base_parameter.py 90.47% <90.90%> (+0.47%) ⬆️

@BradyPlanden BradyPlanden merged commit 490b86a into develop Nov 3, 2023
18 checks passed
@BradyPlanden BradyPlanden deleted the 69-bug-prior-sampling-outside-of-bounds-causes-runtime-error branch November 3, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Prior sampling outside of bounds causes runtime error
1 participant