-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Welcome screen quickstart improvements #2318
base: master
Are you sure you want to change the base?
Conversation
Thanks for working on this. Some suggestions to improve it even more:
|
Thanks for the prompt comment.
export type FileMetadata = Readonly<{
/** A globally unique identifier that serves a a file handle. */
uuid: UUID;
/** The path of the file in storage. */
path: string;
/** The SHA256 hash of the file contents. */
sha256: string;
/** The text editor view state. */
viewState: monaco.editor.ICodeEditorViewState | null;
}>; |
Pretty much. Although IMHO, vertically aligned and slightly bigger text would be more ascetically pleasing. (I didn't spend much time on this, so text is probably a bit larger than what I had in mind compared to the scale of the rest of the app that isn't pictured)
We could add a saga that subscribes to the file open/activate events that writes an array of file names where the currently viewed file always gets bumped to the front of the list. This way, we could avoid file metadata. Or we could modify the DB to have a last viewed timestamp that gets updated by a similar saga. I don't really have a preference one way or the other at this point. |
work in progress, welcome page to refresh dynamically
Thanks for this one! To save yourself some time for future submissions, please do feel free to discuss a sketch or mockup first.
How about keeping this very simple? The linked issue is about users sometimes not being able to find the file menu when it is closed. Presenting a few recent files on the main screen does not necessarily solve that problem. And potentially amplifies it --- "I see three files, where is the rest?" Or people might think they have to close all their files just to open another. There may be simpler possibilities: Option 1: No new UI --- if Pybricks Code is opened, simply have the file menu open by default. Also, if there are no files yet, show italic placeholder text Create a file to begin... at the location where the first file would be. Option 2: All of option 1 and show the welcome tour if Pybricks is opened without any files. Option 3: As discussed in the original issue and your initial PR. I don't think the button would be doing nothing. It could just say either "Show files" or "Hide files". After writing this down, I think option 1 makes sense, even independently from this issue. Since opening the file tab is needed in 99% of cases, this really should be the default. The problem with option 3 is that it essentially duplicates two buttons, which is not ideal in any UI, so that was a bad suggestion on my part in pybricks/support#1264. |
I guess we are back on the design board so might make sense to return to the pybricks/support#1264 issue to clarify and agree on a target set. |
Welcome screen improvements inspired for pybricks/support#1264