Merge pull request #1254 from alex/check-for-errors

Check for errors when invoking the vectors setup.py
pyca · Jul 11, 2014 · 1872e75 · 1872e75
2 parents cb70d20 + d9f9b75
commit 1872e75
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/setup.py b/setup.py
@@ -110,8 +110,9 @@ def finalize_options(self):
         # This means there's a vectors/ folder with the package in here.
         # cd into it, install the vectors package and then refresh sys.path
         if VECTORS_DEPENDENCY not in test_requirements:
-            subprocess.Popen([sys.executable, "setup.py", "install"],
-                             cwd="vectors").communicate()
+            subprocess.check_call(
+                [sys.executable, "setup.py", "install"], cwd="vectors"
+            )
             pkg_resources.get_distribution("cryptography_vectors").activate()
 
     def run_tests(self):