verification: add RFC822Name #10487
Merged
verification: add RFC822Name #10487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
woodruffw
commented
Feb 26, 2024
| use asn1::IA5String; | ||
|
|
||
| // RFC 2822 3.2.4 | ||
| static ATEXT_CHARS: &str = "!#$%&'*+-/=?^_`{|}~"; |
There was a problem hiding this comment.
This might make more sense/be more efficient as &[u8] instead.
Signed-off-by: William Woodruff <william@yossarian.net>
alex
reviewed
Feb 26, 2024
Signed-off-by: William Woodruff <william@yossarian.net>
alex
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backing piece for #10345. Once merged, I'll do a follow up PR for
RFC822Constraintfor the Name Constraint side.Flagging one thing: this implementation doesn't currently bother with the "quoted" form of mailbox names. These are treated as invalid addresses for the time being, and I've added a testcase as a backstop for that behavior so that it doesn't change unexpectedly.
(I can try with the quoted form, but it'll probably make a PR a decent bit bigger and may just be worth a crate that gets it right. They're also uncommon and the relevant RFCs advise against using them for compatibility reasons.)