-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x509 Verification: Extension policies documentation. #11800
base: main
Are you sure you want to change the base?
x509 Verification: Extension policies documentation. #11800
Conversation
d7c5ebd
to
649dd50
Compare
docs/x509/verification.rst
Outdated
.. staticmethod:: webpki_defaults_ca() | ||
|
||
Creates an ExtensionPolicyBuilder initialized with a | ||
CA extension policy based on CA/B Forum guidelines. | ||
|
||
This is the CA extension policy used by :class:`PolicyBuilder`. | ||
|
||
:returns: An instance of :class:`ExtensionPolicyBuilder` | ||
|
||
.. staticmethod:: webpki_defaults_ee() | ||
|
||
Creates an ExtensionPolicyBuilder initialized with an | ||
EE extension policy based on CA/B Forum guidelines. | ||
|
||
This is the EE extension policy used by :class:`PolicyBuilder`. | ||
|
||
:returns: An instance of :class:`ExtensionPolicyBuilder` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@woodruffw right now our extension policies are basically "CABF, but with some things loosened where necessary in practice", is there a good way of articulating that for users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@woodruffw right now our extension policies are basically "CABF, but with some things loosened where necessary in practice", is there a good way of articulating that for users?
Sorry, missed this ping originally!
Maybe something like "these extension policies are intended to be strictly consistent with CABF, which dictates the requirements for certificates on the public web. However, we make limited exceptions to CABF where necessary in practice, i.e. behaviors that CABF forbids but are nonetheless present in the current Web PKI."
But maybe that's too much of a mouthful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can put it in a glossary entry or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure how to formulate this as a glossary entry. What would be the entry name? I would appreciate if someone could write out the full text of the entry here (or just made a separate PR for this).
Hey, @alex, friendly ping 😄 |
Not forgotten! On my TODO list, hopefully this evening. Thanks so much for your patience, and sorry I've been so slow. Don't feel bad about pinging me. |
No worries at all, my plate is also very full right now, so I wouldn't have gotten to doing any actual changes before this weekend at the earliest anyways. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few tiny notes, but overall I think this design works.
Not going to merge until we have an implementation of course.
.. versionchanged:: 44.0.0 | ||
``verification_time`` and ``max_chain_depth`` were replaced by the | ||
``policy`` property that provides access to these values. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to keep these around as proxies, but this isn't terrible important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add that at a later time if it's deemed required. The API is declared as being unstable in the docs, but I understand that we shouldn't go out of our way to introduce breaking changes 😄 Let's keep this conversation unresolved so once we get back to this PR we can look into this again.
Hi, sorry for disappearing for so long - other responsibilities caught up to me and I couldn't find the time unfortunately. I'll start preparing the main PR for primetime now, hopefully I'll be able to open it this year 😅 |
0639af6
to
bf4412d
Compare
*rebased on main to keep my local branches in sync and based on main. |
Finally coming back with another PR. The idea is that this one will serve to confirm the user-facing API for custom extension policy support, and the next one will have the first parts of the implementation.