PKCS7: added encryption with AES-256-CBC #12172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitneuqr
force-pushed
the
aes-256-cbc-encrypt
branch
from
6cde053 to
cc79ad2
Compare
alex
reviewed
Dec 20, 2024
|
Made some changes to adapt, let me know what you think @alex ! |
alex
reviewed
Dec 21, 2024
Comment on lines
270
to
272
| self._content_encryption_algorithm = ( | ||
| self._content_encryption_algorithm or algorithms.AES128 | ||
| ) |
There was a problem hiding this comment.
Don't mutate self here, just use a local. You'll get wrong behavior on a reused builder.
There was a problem hiding this comment.
Good catch! I'll need to modify the rust code accordingly
|
Looks like there's a merge conflict in the changelog. can you rebase/merge main before I review? |
added & updated tests accordingly updated documentation removed useless test vector
changed name to content_encryption_algorithm simplified the rust code accordingly tried to simplify the documentation
adapted rust code accordingly
nitneuqr
force-pushed
the
aes-256-cbc-encrypt
branch
from
84fdaca to
b29e77d
Compare
Yup, done! |
alex
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things to check:
content_algorithminstead of justalgorihmmodeincluded (as we might need it on next S/MIME versions), should I include it now?