Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyo3: bump version to v0.24.0 #12631

Closed
wants to merge 1 commit into from

Conversation

SilverBzH
Copy link

pyo3 version prior to 0.24.0 are not able to parse
properly exotic python version. This is fix since
PyO3/pyo3#4949 available on the
v0.24.0 version

pyo3 version prior to 0.24.0 are not able to parse
properly exotic python version. This is fix since
PyO3/pyo3#4949 available on the
v0.24.0 version
@alex
Copy link
Member

alex commented Mar 17, 2025

When updating Cargo.toml, Cargo.lock needs to be updated as well. But either way it won't work due to: PyO3/pyo3#4965

@SilverBzH
Copy link
Author

Ah, indeed. Let's wait until 0.25.0 then I guess. I'll properly push the Cargo.lock as well if that's works for you ?

@alex
Copy link
Member

alex commented Mar 17, 2025

Sure, go for it. There's at least one other change that will be required, even once a release pyo3 with a fix is out.

@SilverBzH
Copy link
Author

SilverBzH commented Mar 17, 2025

Do you have a link the change needed ? Then I can follow it.

@alex
Copy link
Member

alex commented Mar 17, 2025

If you read the failing logs, you'll see that there's three compilation errors. Two are related to the issue I linked, one requires a change from us.

@SilverBzH
Copy link
Author

Ok sounds good. Once the issue on pyo3 side is solved, I'll update this PR with the right version. Then I'll wait for your green flag from there 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants