Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing padding from the encryption API #30

Merged
merged 1 commit into from
Aug 10, 2013
Merged

Removing padding from the encryption API #30

merged 1 commit into from
Aug 10, 2013

Conversation

dstufft
Copy link
Member

@dstufft dstufft commented Aug 10, 2013

  • Padding is fundamentally an operation that occurs prior to encryption to make plaintext suitable.
  • Even though wether it's regarded is dependent on the mode, it can be used safely regardless.
  • Moving it out of this API makes the API's simpler and more composable.
  • Moving it out of this API makes it simpler for backends that don't work exactly like OpenSSL's EVP.
  • Move it out of this API makes it simpler to include padding that OpenSSL's EVP API doesn't expose.

@dstufft
Removing padding from the encryption API
a02d4ed 
* Padding is fundamentally an operation that occurs prior to
  encryption to make plaintext suitable.
* Even though wether it's regarded is dependent on the mode, it
  can be used safely regardless.
* Moving it out of this API makes the API's simpler and more
  composable.
* Moving it out of this API makes it simpler for backends that
  don't work exactly like OpenSSL's EVP.
* Move it out of this API makes it simpler to include padding
  that OpenSSL's EVP API doesn't expose.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a02d4ed on dstufft:simplify-api into 80bb237 on alex:master.

@dstufft dstufft mentioned this pull request Aug 10, 2013
Merged
5 tasks
@hynek
Copy link
Contributor

hynek commented Aug 10, 2013

Pudding ist not encrypting so that move makes sense to me.

alex added a commit that referenced this pull request Aug 10, 2013
@alex
Merge pull request #30 from dstufft/simplify-api
34c7a91 
Removing padding from the encryption API
@alex alex merged commit 34c7a91 into pyca:master Aug 10, 2013
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dstufft @coveralls @hynek @alex