Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write a bunch of primitives tests as subtests for performance #5246

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Write a bunch of primitives tests as subtests for performance #5246

merged 1 commit into from
Dec 9, 2020

Conversation

alex
Copy link
Member

@alex alex commented May 11, 2020

No description provided.

@alex alex changed the title Write a bunch of primitives tests as subtests for performance Write a bunch of primitives tests as for-loops for performance May 12, 2020
@alex
Copy link
Member Author

alex commented May 12, 2020

19:09:24 <Alex_Gaynor> reaperhulk: ah fuck, there's a problem with just doing a loop. pytest.skip() raises an exception, which means all subsequent tests in the bundle get skipped, not just that test.
19:10:00 <Alex_Gaynor> reaperhulk: this means we're skipping a ton of tests, and probably significantl contributes to the perf difference (e.g. none of the kbkdf ones are running, because the first thing in that vector is skipped)
19:10:58 <Alex_Gaynor> reaperhulk: this is why we need real subtest support

Since pytest-subtests is py3 only, I'm not sure what to do. 25% of our downloads are still py2, so just drop it isn't on the table ATM.

@alex alex changed the title Write a bunch of primitives tests as for-loops for performance Write a bunch of primitives tests as subtests for performance Jun 25, 2020
@alex alex marked this pull request as draft June 25, 2020 23:41
@alex
Copy link
Member Author

alex commented Jun 25, 2020

Converted to a draft, since I don't think we have a way forward until the far future when we're py3 only.

@alex alex force-pushed the pytest-subtest branch 4 times, most recently from a0ab40a to c94282e Compare July 22, 2020 19:23
@reaperhulk reaperhulk mentioned this pull request Jul 28, 2020
Closed
@alex alex force-pushed the pytest-subtest branch 2 times, most recently from a736769 to e07d836 Compare August 15, 2020 15:04
@opendev-zuul
Copy link

opendev-zuul bot commented Aug 15, 2020

Build failed (check pipeline). For information on how to proceed, see
https://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing

@opendev-zuul
Copy link

opendev-zuul bot commented Aug 15, 2020

Build succeeded (check pipeline).

@alex alex added this to the Thirty Fourth Release milestone Dec 5, 2020
@alex alex marked this pull request as ready for review December 9, 2020 05:18
reaperhulk
reaperhulk reviewed Dec 9, 2020
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@reaperhulk reaperhulk merged commit b3540ec into pyca:master Dec 9, 2020
@alex alex deleted the pytest-subtest branch December 9, 2020 06:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reaperhulk reaperhulk reaperhulk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
Thirty Fourth Release
Development

Successfully merging this pull request may close these issues.
2 participants
@alex @reaperhulk