Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port a tiny tiny bit of the ASN.1 parsing to Rust #5357

Merged
merged 1 commit into from
Apr 11, 2021
Merged

Port a tiny tiny bit of the ASN.1 parsing to Rust #5357

merged 1 commit into from
Apr 11, 2021

Conversation

alex
Copy link
Member

@alex alex commented Jul 27, 2020 •
edited
Loading

@alex alex mentioned this pull request Jul 27, 2020
Merged
@alex
Copy link
Member Author

alex commented Jul 27, 2020

We'll need PyO3/setuptools-rust#68 before it's possible to consider something like this.

@alex alex force-pushed the rust-asn1-parser branch 3 times, most recently from bd15efb to 745c650 Compare July 30, 2020 00:34
@alex alex force-pushed the rust-asn1-parser branch 2 times, most recently from 96262c7 to c2aaf68 Compare August 6, 2020 13:00
@opendev-zuul

This comment has been minimized.

Sign in to view
@alex alex force-pushed the rust-asn1-parser branch 4 times, most recently from 9beb69d to cbcfae7 Compare August 6, 2020 13:17
@opendev-zuul

This comment has been minimized.

Sign in to view
@alex alex force-pushed the rust-asn1-parser branch from cbcfae7 to 8f9418d Compare August 6, 2020 14:44
@opendev-zuul

This comment has been minimized.

Sign in to view
@alex alex force-pushed the rust-asn1-parser branch from 8f9418d to 032afe2 Compare August 7, 2020 16:35
@opendev-zuul

This comment has been minimized.

Sign in to view
@alex alex force-pushed the rust-asn1-parser branch from 032afe2 to 6a019b9 Compare August 7, 2020 17:20
@opendev-zuul

This comment has been minimized.

Sign in to view
@alex alex force-pushed the rust-asn1-parser branch from 6a019b9 to 802c8ba Compare August 7, 2020 17:45
@opendev-zuul

This comment has been minimized.

Sign in to view
@alex alex force-pushed the rust-asn1-parser branch 2 times, most recently from 2b7a8b6 to 9106c59 Compare August 7, 2020 19:15
@opendev-zuul

This comment has been minimized.

Sign in to view
@alex alex force-pushed the rust-asn1-parser branch from 9106c59 to 4495275 Compare August 7, 2020 22:10
@opendev-zuul

This comment has been minimized.

Sign in to view
@alex alex force-pushed the rust-asn1-parser branch from 4495275 to d9b26e5 Compare August 7, 2020 22:21
@opendev-zuul

This comment has been minimized.

Sign in to view
@alex alex force-pushed the rust-asn1-parser branch 2 times, most recently from 2236059 to 5013f69 Compare August 7, 2020 22:50
@opendev-zuul

This comment has been minimized.

Sign in to view
@alex alex force-pushed the rust-asn1-parser branch from 5013f69 to 1375576 Compare August 7, 2020 23:15
@opendev-zuul

This comment has been minimized.

Sign in to view
@alex alex mentioned this pull request Aug 7, 2020
Closed
@reaperhulk reaperhulk mentioned this pull request Oct 25, 2020
Closed
@alex alex mentioned this pull request Dec 2, 2020
Closed
@reaperhulk reaperhulk added this to the Thirty Fifth Release milestone Dec 25, 2020
@tiran tiran mentioned this pull request Feb 8, 2021
Closed
Base automatically changed from master to main February 12, 2021 02:15
@alex alex force-pushed the rust-asn1-parser branch 8 times, most recently from f9d3ac6 to c5ec562 Compare February 23, 2021 12:47
@alex alex force-pushed the rust-asn1-parser branch 2 times, most recently from be54f02 to 037b59a Compare April 5, 2021 00:13
@alex alex force-pushed the rust-asn1-parser branch from 037b59a to 01b549d Compare April 11, 2021 20:21
@alex alex marked this pull request as ready for review April 11, 2021 20:22
reaperhulk
reaperhulk approved these changes Apr 11, 2021
View reviewed changes
Copy link
Member

@reaperhulk reaperhulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alex and I pair reviewed this (and rust-asn1) over a few hours, so the lack of comments before approval is not indicative of the level of review scrutiny.

@reaperhulk reaperhulk merged commit ead8275 into pyca:main Apr 11, 2021
@alex alex deleted the rust-asn1-parser branch April 11, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reaperhulk reaperhulk reaperhulk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
Thirty Fifth Release
Development

Successfully merging this pull request may close these issues.
2 participants
@alex @reaperhulk