be more verbose in the 102 deprecation notice #5505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
Oct 25, 2020
| "cryptography you need to upgrade to a newer version of " | ||
| "OpenSSL. For this version only you can also set the " | ||
| "environment variable CRYPTOGRAPHY_ALLOW_OPENSSL_102 to " | ||
| "allow OpenSSL 1.0.2." |
There was a problem hiding this comment.
We have not included this in previous OpenSSL version droppings, and instead referred people to the docs. Why now?
There was a problem hiding this comment.
Because I've fielded at least one question on StackOverflow where it turns out they broke their pip (due to the pyOpenSSL + cryptography on older pip/Python). They couldn't find the docs because we only keep them around for one version and I'd rather make it obvious how to fix it directly in the error.
alex
approved these changes
Oct 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.