padding: Tip-toe around bytes subclasses. #5548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
Nov 2, 2020
benjaminp
force-pushed
the
terrible-padding-hacks
branch
from
4d1a41e
to
9a97462
Compare
|
pep8/black errors. |
benjaminp
force-pushed
the
terrible-padding-hacks
branch
5 times, most recently
from
777f5ad
to
1c2cbe7
Compare
This change allows future's newbytes class to be padded again. Fixes pyca#5547.
benjaminp
force-pushed
the
terrible-padding-hacks
branch
from
1c2cbe7
to
2ab719c
Compare
reaperhulk
approved these changes
Nov 4, 2020
Thank you very much for putting up with it.
The regression is preventing me from going past 3.2, but that's not urgent for me at the moment. Just doing my regular update cadence for libraries. Before you drop Python 2 support would be good. |
|
We will definitely do a 3.3 release with this. That release is likely to be our final 2.7 release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows future's newbytes class to be padded again.
Fixes #5547.