-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: test on macos big sur #5647
Conversation
.github/workflows/wheel-builder.yml
Outdated
@@ -55,14 +55,17 @@ jobs: | |||
path: cryptography-wheelhouse/ | |||
|
|||
macos: | |||
runs-on: macos-latest | |||
runs-on: ${{ matrix.os }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no need to do change our wheel builder, the wheels we build already work with any macOS version 10.10 and greater.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should probably have opened an issue first, but the prebuilt-wheel does not work on mac 11, it tries to re-compile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying upgrading to a newer pip. It sounds like you're hitting pypa/pip#9138
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, I'll remove the duplicated release job then!
I appreciate the fact that this PR is well-structured (really!), but we won't merge this for somewhat counterintuitive reasons.
All the previous being said, clearly our CI will expand when arm64 macOS becomes available to us since that different arch (and the need to build wheels against it!) is sufficiently different to warrant CI resourcing. |
OK! I understand, thank you anyway! |
Add jobs to test on MacOS Big Sur