fix signature of EllipticCurvePublicKey.verify() #5808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature change was introduced in pyca#5729 but is inconsistent with respect to related methods, breaks backward compatibility and compatibility with the OpenSSL backend (and maybe other backends) when named arguments are used.
alex
approved these changes
Feb 10, 2021
|
To clarify: It does not break functionality per se, but is confusing (for |
|
@alex was this updated in docs or did we not change it? IIRC there were several other places names were changed as well. Should we revert that? |
|
Those changes may not propagate to the backends though. If not they can stay |
|
I don't think any of the other changes impacted interfaces in this way.
…On Wed, Feb 10, 2021 at 10:08 AM Paul Kehrer ***@***.***> wrote:
@alex <https://github.com/alex> was this updated in docs or did we not
change it? IIRC there were several other places names were changed as well.
Should we revert that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5808 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBG2BQY5I4FQJ7ZLJATS6KON3ANCNFSM4XNCFFXQ>
.
--
All that is necessary for evil to succeed is for good people to do nothing.
|
reaperhulk
pushed a commit
to reaperhulk/cryptography
that referenced
this pull request
Feb 13, 2021
The signature change was introduced in pyca#5729 but is inconsistent with respect to related methods, breaks backward compatibility and compatibility with the OpenSSL backend (and maybe other backends) when named arguments are used.
alex
added a commit
that referenced
this pull request
Feb 13, 2021
* Bump pyo3 and lower MSRV (#5823) * fix signature of EllipticCurvePublicKey.verify() (#5808) The signature change was introduced in #5729 but is inconsistent with respect to related methods, breaks backward compatibility and compatibility with the OpenSSL backend (and maybe other backends) when named arguments are used. * Name: update get_attributes_for_oid return type (#5809) `List` gives more power to the caller. Note that `RelativeDistinguishedName`, the same function returns a `List`. Is there a reason this was `Iterable` only for `Name`? If we don't want to promise `List`, `Sequence` is another alternative. * Start typing a bunch of stuff from x509 extensions (#5812) * part 2 of typing x509 extensions (#5815) * 3.4.5 changelog and version bump * spelling * fix a false positive from the latest clippy (#5813) Co-authored-by: Alex Gaynor <alex.gaynor@gmail.com> Co-authored-by: Markus Wamser <wamserma@users.noreply.github.com> Co-authored-by: Dan Halperin <dhalperi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature change was introduced in #5729 but is inconsistent with respect to related methods, breaks backward compatibility and compatibility with the OpenSSL backend (and maybe other backends) when named arguments are used.
The issue is present for all versions >= 3.4.