Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace release.py with OIDC publishing #8483

Merged
merged 1 commit into from
Mar 11, 2023
Merged

Replace release.py with OIDC publishing #8483

merged 1 commit into from
Mar 11, 2023

Conversation

alex
Copy link
Member

@alex alex commented Mar 9, 2023

We are now in the PyPI OIDC publishing beta

@alex
Copy link
Member Author

alex commented Mar 9, 2023

When this is merged it needs to be configured at https://pypi.org/manage/project/cryptography/settings/publishing/

@alex
Copy link
Member Author

alex commented Mar 10, 2023

Plan of action:

  • Add support for workflow_dispatch and publishing to Test PyPI
  • Get ownership of the Test PyPI package
  • Merge
  • Do a test run publishing to Test PyPI, rinse and repeat until successful
  • Re-enable the workflow_run path
  • Configure on PyPI.

@alex alex force-pushed the oidc-publishing branch 2 times, most recently from ac2cc00 to a7c77d7 Compare March 10, 2023 15:19
@di
Copy link
Contributor

di commented Mar 10, 2023

@alex, What's your TestPyPI username? I'll need to put you in the beta there too but don't see an alexgaynor user.

@alex
Copy link
Member Author

alex commented Mar 10, 2023

@di I didn't have one, I've just created one with the same name (alexgaynor).

(I also don't currently own the "cryptography" package on Test PyPI, but I've emailed the current owner to see if I can get it.)

@di
Copy link
Contributor

di commented Mar 10, 2023

Thanks, I put you in the beta and also made you owner of the TestPyPI package.

@alex
Copy link
Member Author

alex commented Mar 10, 2023

Swell, thanks!

@alex
Copy link
Member Author

alex commented Mar 10, 2023

Test PyPI is now configured for this workflow, just need a review from @reaperhulk

We are now in the PyPI OIDC publishing beta
Copy link
Member

@reaperhulk reaperhulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let the experiment begin

@reaperhulk reaperhulk merged commit 22ae4d8 into main Mar 11, 2023
@reaperhulk reaperhulk mentioned this pull request Mar 11, 2023
6 tasks
@alex alex deleted the oidc-publishing branch March 11, 2023 04:35
@webknjaz
Copy link
Contributor

@alex any reason you didn't go for https://github.com/marketplace/actions/pypi-publish#trusted-publishing that embeds the OIDC logic?

@webknjaz
Copy link
Contributor

Ah.. you made this 5 days before pypa/gh-action-pypi-publish#123 got merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants