Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only check DH key validity when loading a private key. #9071

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Only check DH key validity when loading a private key. #9071

merged 1 commit into from
Jun 17, 2023

Conversation

alex
Copy link
Member

@alex alex commented Jun 13, 2023

Fixes #9063

@alex alex mentioned this pull request Jun 13, 2023
Closed
reaperhulk
reaperhulk approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@reaperhulk reaperhulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This returns us to pre-rust behavior. Checking the key is safer but check cost is very high (two Miller-Rabin primality checks + a modexp). Future folks should consider whether we want to do an unsafe load kwarg like we do for RSA.

@reaperhulk reaperhulk merged commit b0e31ed into pyca:main Jun 17, 2023
@alex alex deleted the dh-validity branch June 17, 2023 12:57
jtougas pushed a commit to jtougas/cryptography that referenced this pull request Jul 31, 2023
@alex @jtougas
Only check DH key validity when loading a private key. (pyca#9071)
4f56dc0 
Fixes pyca#9063
reaperhulk pushed a commit that referenced this pull request Jul 31, 2023
@jtougas @alex
Only check DH key validity when loading a private key. (#9071) (#9319)
774a4a1 
Fixes #9063

Co-authored-by: Alex Gaynor <alex.gaynor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reaperhulk reaperhulk reaperhulk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

key exchange performance degradation
2 participants
@alex @reaperhulk