Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certificate: useful APIs #9300

Merged
merged 15 commits into from
Jul 26, 2023
Merged

Certificate: useful APIs #9300

merged 15 commits into from
Jul 26, 2023

Conversation

woodruffw
Copy link
Contributor

More breakout from #8873.

woodruffw added 2 commits July 26, 2023 17:35
@woodruffw
certificate: new APIs
0862f4f 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
certificate: docs
8e5e703 
Signed-off-by: William Woodruff <william@trailofbits.com>
alex
alex reviewed Jul 26, 2023
View reviewed changes
src/rust/cryptography-x509/src/certificate.rs Outdated Show resolved Hide resolved
src/rust/cryptography-x509/src/certificate.rs Outdated Show resolved Hide resolved
src/rust/cryptography-x509/src/certificate.rs Outdated Show resolved Hide resolved
woodruffw added 5 commits July 26, 2023 17:51
@woodruffw
certificate: remove some APIs
b9bd4c8 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
remove import
ee514c1 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
rust: fixup error types
4b85e40 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
extensions: Debug
8feec27 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
certificate: remove CertificateError
e76fcac 
Signed-off-by: William Woodruff <william@trailofbits.com>
alex
alex reviewed Jul 26, 2023
View reviewed changes
src/rust/src/x509/certificate.rs Outdated Show resolved Hide resolved
src/rust/src/x509/common.rs Outdated Show resolved Hide resolved
@woodruffw
Copy link
Contributor Author

Got rid of the CertificateError entirely and replaced it with an ExtensionsError everywhere -- that completely unifies the error types here and keeps us from breaking the Python bindings by introducing another variant that needs to be handled.

@alex
Copy link
Member

alex commented Jul 26, 2023

Should probably be named DuplicateExtensionError, right÷

@woodruffw
rename error
b2577ca 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
rust: nicer error unpacking
dfef3cc 
Signed-off-by: William Woodruff <william@trailofbits.com>
alex
alex previously approved these changes Jul 26, 2023
View reviewed changes
@alex alex enabled auto-merge (squash) July 26, 2023 22:26
@woodruffw
Copy link
Contributor Author

(Still needs coverage, doing that in a moment.)

woodruffw added 2 commits July 26, 2023 18:30
@woodruffw
certificate: use extensions()
f01254a 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
rust: use subject() and issuer() APIs
705de99 
Signed-off-by: William Woodruff <william@trailofbits.com>
auto-merge was automatically disabled July 26, 2023 22:35

Head branch was pushed to by a user without write access

alex
alex previously approved these changes Jul 26, 2023
View reviewed changes
@woodruffw
certificate: rm is_self_issued
13117ad 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
clippage
2f2e29d 
Signed-off-by: William Woodruff <william@trailofbits.com>
alex
alex previously approved these changes Jul 26, 2023
View reviewed changes
@woodruffw
fmt
e909047 
Signed-off-by: William Woodruff <william@trailofbits.com>
alex
alex previously approved these changes Jul 26, 2023
View reviewed changes
@alex alex enabled auto-merge (squash) July 26, 2023 23:03
@woodruffw
extensions: remove Debug
6be59ce 
Signed-off-by: William Woodruff <william@trailofbits.com>
auto-merge was automatically disabled July 26, 2023 23:11

Head branch was pushed to by a user without write access

@alex alex enabled auto-merge (squash) July 26, 2023 23:11
@alex alex merged commit 25d75f0 into pyca:main Jul 26, 2023
@woodruffw woodruffw deleted the ww/certificate-apis branch July 26, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex alex alex approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woodruffw @alex