Expose inter-/histopolation matrices in GlobalProjector, add unit tests #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yguclu, it seems I cannot see why the latest test failed, do you have an idea? Also, did you have time to think about this PR yet? |
yguclu
requested changes
Nov 2, 2023
|
Python 3.11 tests passed upon relaunching test, without changes. |
|
@spossann It seems that the code could be simplified with these steps:
Before making any of these changes, could you please add a parallel test to this PR? |
The function |
yguclu
reviewed
Aug 22, 2024
spossann
referenced
this pull request
Sep 12, 2024
Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>
…1, this fixes the problem with toarray() which did previously not work for StencilMatrix. Updated indexing in KroneckerStencilMatrix to include shift factors in index calculations. Added back the assert statement in GlobalProjector since the toarray() now works. The kernels still don't work properly for different shifts in the domain and the co-domain, but I believe equivalent changes can be done in the remaining kernels.
- Add compiler flags for GFortran >= 14 on Apple silicon chips - Add unit test in `test_epyccel_flags.py` to check compiler flags passed to `epyccel` - Update GitHub actions used in documentation workflow
NumPy 2.1 deprecates the `newshape` argument of the `reshape` function. Instead, one should use the positional-only argument `shape`. Every call in Psydac has been updated accordingly. This closes #432.
Update `apt` index files with `apt-get update` to avoid download error in CI workflow.
Clarify in the `README.md` file that, although the C backend may be selected for accelerating the kernel files with Pyccel, this is not fully working yet. Hence the Fortran backend (which is the default) is the only one available. A future version of Pyccel will certainly provide a C backend as capable as the Fortran one. See issue #431. Co-authored-by: Martin Campos Pinto <campos@ann.jussieu.fr>
The obsolete property `is_block` was never used in Psydac nor in Struphy, hence we remove it. --------- Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>
Fix the indexing in all kernels in `stencil2coo_kernels.py` so that the method `toarray` works for `StencilMatrix` objects in 1D/2D/3D with `shift` larger than 1. The unit tests for `toarray` in `test_stencil_matrix.py` have been parametrized to run with `shift` values of 1 and 2. --------- Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>
yguclu
requested changes
Oct 2, 2024
|
Pushed with the 3D tests uncommented to ensure they all go through. |
yguclu
requested changes
Oct 16, 2024
yguclu
approved these changes
Oct 16, 2024
yguclu
requested changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #346.
The inter-/histopolation matrices are now exposed in
GlobalProjector.imat_kroneckeras aLinearOperatorobject of typeKroneckerStencilMatrix(in the case where both domain and codomain are scalar spaces) orBlockLinearOperator(in the case where at least one space is vector valued).The unit tests in
feec/tests/test_commuting_projections.pyhave been enhanced: they now also test how closeimat_kroneckeris to being the right-inverse of thesolverattribute (which uses a Kronecker product of 1D linear solvers).