Fix offset error in _PaddedFile caused by concatenated gzips. #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the bitbuffer the prepended data can be bigger than the original buffer. This was not expected by the _PaddedFile object
Codecov Report
@@ Coverage Diff @@
## develop #61 +/- ##
===========================================
+ Coverage 99.50% 99.53% +0.02%
===========================================
Files 2 2
Lines 204 214 +10
===========================================
+ Hits 203 213 +10
Misses 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not need to be fixed upstream in Cpython's gzip.py.
The error is due to isal_zlib's bitbuffer and thus not applicable to cpython.
Fixes #60
Checklist