-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add django-dynamic-form to the project #293
Conversation
questionnaires/views.py
Outdated
from .models import FormForTicket | ||
|
||
|
||
class ShowFormForTicket(DynamicFormView): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ricco386 I am having some difficulties with this class based view.
when I visit /form/1/ticket/my_uuid/
the dispatch
is invoked as supposed but when I submit the form, form_valid
is not invoked, however the form_valid
in DynamicFormView
is. So basically I cannot override the method and I have no idea why. Any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the meantime I found out where is the problem.
Current coverage is 92.51% (diff: 100%)@@ master #293 diff @@
==========================================
Files 68 68
Lines 2044 2044
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1891 1891
Misses 153 153
Partials 0 0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a basic documentation, at least few steps how to integrate with django-konfera properly.
- Installed requirements
- Update project installed apps (dynamic_forms, questionaires)
Migration fails in the dynamic forms 0.5.3 as it is missing migration 0006 pip installed version of lib has only migration 0005 and therefore manage.py fails and migration 0006 doesnt seems to be on github either.
What shall I do?
@@ -0,0 +1 @@ | |||
django-dynamic-forms-0.5.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the typo
@@ -4,3 +4,4 @@ django-sitetree==1.6.0 | |||
mock==2.0.0 | |||
pytz==2016.7 | |||
Pillow==3.4.2 | |||
django-dynamic-forms-0.5.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the typo
As the app is going to be refactored and simplified (#320), I close this PR. |
todo: