Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top level project cleanup #321

Merged
merged 1 commit into from
Aug 19, 2017
Merged

Top level project cleanup #321

merged 1 commit into from
Aug 19, 2017

Conversation

ZoltanOnody
Copy link
Member

No description provided.

@ZoltanOnody ZoltanOnody force-pushed the v2.0-zoli branch 2 times, most recently from c737ba5 to c64aeb5 Compare August 18, 2017 22:12
@codecov-io
Copy link

codecov-io commented Aug 18, 2017

Codecov Report

Merging #321 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #321   +/-   ##
=======================================
  Coverage   88.11%   88.11%           
=======================================
  Files          74       74           
  Lines        2289     2289           
=======================================
  Hits         2017     2017           
  Misses        272      272

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1072778...2a8b86d. Read the comment docs.

@ricco386
Copy link
Member

You have crated the PR against master, we have agreed that until we have minimal working version we will have it in a branch and than switch it to the master.

Can you change it to be against branch v2.0? Otherwise looks good, we have deleted a lot of stuff ;)

@ZoltanOnody ZoltanOnody changed the base branch from master to v2.0 August 19, 2017 08:31
@ricco386 ricco386 merged commit 08dcc8b into v2.0 Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants