Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no python 2.4 support #22

Closed
JensTimmerman opened this issue Oct 15, 2012 · 5 comments
Closed

no python 2.4 support #22

JensTimmerman opened this issue Oct 15, 2012 · 5 comments

Comments

@JensTimmerman
Copy link
Contributor

I liked to use ansi2html on a system with only python 2.4 support, so I added python 2.4 support in my branch
https://github.com/JensTimmerman/ansi2html/tree/develop/ansi2html

Should I switch this to a feature branch and make a pull request?

@ralphbean
Copy link
Collaborator

That would be great! :) That way we can look it over and poke at it.

If you add python 2.4 to the .travis.yml file, then travis can run the test suite on all the versions of python listed there.

@JensTimmerman JensTimmerman mentioned this issue Oct 15, 2012
@JensTimmerman
Copy link
Contributor Author

I added python 2.4 to .travis.yml
But travis doesn't seem willing to support python 2.4, so now that build is failing...

@ralphbean
Copy link
Collaborator

Fixed in 6fcc5ab It is available from pypi starting with release 0.9.3.

Thanks again!

@JensTimmerman
Copy link
Contributor Author

Thank you for merging this.
However, if you are willing to keep supporting python 2.4 you'll have to take care to use the string interpolation (%) instead of format (which is a bit slower)
Use the hackish Ternary conditional operator ('False','True')[condition]

And in general you'll be a bit more limited.

I was surprised everything still worked after removing the __future__ imports...

@ralphbean
Copy link
Collaborator

Yeah, it looks like many of the __future__ references were artifacts from when I originally ran "python-modernize". :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants