Add ability to also recognize colons in ANSI escapes #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Can you please provide some backing for making this change? After 20+ years of using ANSI that is the first time when I hear about using colons. A quick search on wikipedia. There is a section on 24-bit which mentions as being included in ODA, a commercial failure. https://en.wikipedia.org/wiki/ANSI_escape_code Basically what bug does this fix? |
|
See issue #166 for the full story. |
ssbarnea
changed the title
ssbarnea
approved these changes
Feb 16, 2022
hartwork
requested changes
Feb 16, 2022
ansi2html/converter.py
Outdated
Comment on lines
457
to
461
| params = [ | ||
| int(item) | ||
| for subitem in [x.split(":") for x in params.split(";")] | ||
| for item in subitem | ||
| ] |
There was a problem hiding this comment.
That seems to be way more complex than ideal and necessary. Would this approach work?:
In [7]: [int(v) for v in re.split("[:;]", "111;222:333;444")]
Out[7]: [111, 222, 333, 444]
There was a problem hiding this comment.
Probably. I keep forgetting that re.split() exists.
There was a problem hiding this comment.
@jaysonlarose if you could simplify the code using re.split, I would consider it ready to merge. Thank you!
hartwork
approved these changes
Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically just treats colons and semicolons as exactly the same when it comes to parsing ANSI.
Fixes: #166